[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1081141 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Sun, 13 Mar 2011 21:57:18 +0300

On Sun, Mar 13, 2011 at 18:38, <lgo_at_apache.org> wrote:
> Author: lgo
> Date: Sun Mar 13 15:38:01 2011
> New Revision: 1081141
>
> URL: http://svn.apache.org/viewvc?rev=1081141&view=rev
> Log:
> ra_serf: Drastically limit memory usage on large checkouts. Stop reading the update
> report response when too many fetches/propfinds are already active.
>
> * subversion/libsvn_ra_serf/update.c
>  (MAX_OUTSTANDING_REQS): New define.
>  (throttled_handle_xml_parser): Wraps a normal xml parser, stops reading when too
>   many active requests.
>  (finish_report): use the new throttled_handle_xml_parser.
>
>
Hi Lieven,

I understand the problem, but on my Windows box your change has three problems:
1. svn export uses 100% CPU, because serf call
throttled_handle_xml_parser all the time. Because APR_POLLIN is still
enabled in pollset.

2. Memory usage didn't change on my tests, svn export of svn-trunk
still uses 50MB of memory

3. Time of svn export increased from 50s to 120s.

-- 
Ivan Zhakov
Received on 2011-03-13 19:58:14 CET

This is an archived mail posted to the Subversion Dev mailing list.