Re: svn commit: r1080034 - /subversion/trunk/subversion/libsvn_repos/log.c
On Wed, Mar 9, 2011 at 17:17, <pburba_at_apache.org> wrote:
> Author: pburba
> Date: Wed Mar 9 22:17:10 2011
> New Revision: 1080034
> URL: http://svn.apache.org/viewvc?rev=1080034&view=rev
> Follow-up to issue #3176 fix in r1079983.
> * subversion/libsvn_repos/log.c
> (get_combined_mergeinfo_changes): svn_mergeinfo_merge does *not* make a
> deep copy of the incoming mergeinfo, so we need to use a long-lived pool
> when creating those incoming mergeinfos with svn_mergeinfo_diff.
I strongly suggest putting this into a comment in the code. Otherwise,
somebody is going to come along and switch that back to an iterpool.
They certainly are not going to look at log messages first.
Received on 2011-03-10 03:40:49 CET
This is an archived mail posted to the Subversion Dev