[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1079008 - /subversion/trunk/subversion/svnadmin/main.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 8 Mar 2011 15:18:07 +0100

> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan_at_visualsvn.com]
> Sent: dinsdag 8 maart 2011 15:08
> To: Philip Martin; dev_at_subversion.apache.org
> Cc: Stefan Sperling
> Subject: Re: svn commit: r1079008 -
> /subversion/trunk/subversion/svnadmin/main.c
>
> On Tue, Mar 8, 2011 at 17:01, Stefan Sperling <stsp_at_elego.de> wrote:
> > On Tue, Mar 08, 2011 at 01:46:23PM +0000, Philip Martin wrote:
> >> stefan2_at_apache.org writes:
> >>
> >> > Author: stefan2
> >> > Date: Mon Mar 7 22:57:04 2011
> >> > New Revision: 1079008
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=1079008&view=rev
> >> > Log:
> >> > Set FSFS cache default size to 16 MB. This is the same default as
> >> > for everybody else, namely the server processes. Thus, it should
> >> > be reasonable value on the same machines.

<snip>

> > Shouldn't the cache be off by default?
> >
> > We have precedence for other features like this that are strictly opt-in,
> > e.g. memcached support in FSFS. I don't think we should assume that the
> > new cache code is perfect and enable it by default on any repository for
> > any 1.7 server. The feature has not had any exposure in the real world yet.
> >
> > So I think it would be better if the cache was off by default, and must be
> > enabled in a configuration file. I suppose svnserve and mod_dav_svn
> > configuration files would be the best location for this, because the
> > purpose of the cache seems to be to speed up server operation.
> > An 'svn' process has a short lifetime so the benefit of this cache
> > seems dubious in that situation. I don't see any reason to even provide
> > a way to turn it on there.
> >
> +1!

+1

        Bert
Received on 2011-03-08 15:18:44 CET

This is an archived mail posted to the Subversion Dev mailing list.