[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 03 Mar 2011 16:33:03 +0000

Greg Stein <gstein_at_gmail.com> writes:

> On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright <hyrum_at_hyrumwright.org> wrote:
>> On Thu, Mar 3, 2011 at 9:03 AM,  <philip_at_apache.org> wrote:
>>> Author: philip
>>> Date: Thu Mar  3 15:03:42 2011
>>> New Revision: 1076645
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1076645&view=rev
>>> Log:
>>> Wrap pointer in a baton to avoid a complier warning or cast.
>>
>> I think a single cast is better than the obfuscation of wrapping a
>> single value in a baton.  Please reconsider this change.
>
> Agreed. I'd much rather see (void *)changelist, than all of this stuff.

A cast that changes the type, (void *)changelist, or one that just
removes the qualifier, (char *)changelist? Casts lead to questions.

-- 
Philip
Received on 2011-03-03 17:33:38 CET

This is an archived mail posted to the Subversion Dev mailing list.