[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1076556 - in /subversion/trunk/subversion: libsvn_diff/diff_file.c libsvn_subr/eol.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 3 Mar 2011 12:08:49 +0100

> -----Original Message-----
> From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
> Sent: donderdag 3 maart 2011 9:45
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1076556 - in /subversion/trunk/subversion:
> libsvn_diff/diff_file.c libsvn_subr/eol.c
>
> Author: stefan2
> Date: Thu Mar 3 08:44:40 2011
> New Revision: 1076556
>
> URL: http://svn.apache.org/viewvc?rev=1076556&view=rev
> Log:
> As reported here: http://svn.haxx.se/dev/archive-2011-02/0816.shtml
> the APR does not define APR_SIZEOF_VOIDP properly on Windows x64.
> This quickly leads of segfaults.
>
> Therefore, use a chunk data type that is consistent with whatever APR
> decides APR_SIZEOF_VOIDP to be.
>
> * subversion/libsvn_diff/diff_file.c:
> (contains_eol, find_identical_prefix, find_identical_suffix):
> replace apr_size_t with apr_uintptr_t
> * subversion/libsvn_subr/eol.c:
> (svn_eol__find_eol_start): dito
>
> Reported by: Marc Haesen <Marc.Haesen{_AT_}oneaccess-net.com>

This patch breaks our compatibility with apr 0.9. See the buildbot results.

        Bert
 
Received on 2011-03-03 12:09:16 CET

This is an archived mail posted to the Subversion Dev mailing list.