[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1076098 - /subversion/trunk/subversion/libsvn_wc/wc_db_pdh.c

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 2 Mar 2011 05:04:50 -0500

Line 564 of wc_db_pdh.c is the culprit.

Figuring out a fix...

On Wed, Mar 2, 2011 at 05:03, Greg Stein <gstein_at_gmail.com> wrote:
> Somehow, this broke the build.
>
> Investigating...
>
>
> On Tue, Mar 1, 2011 at 22:07,  <hwright_at_apache.org> wrote:
>> Author: hwright
>> Date: Wed Mar  2 03:07:04 2011
>> New Revision: 1076098
>>
>> URL: http://svn.apache.org/viewvc?rev=1076098&view=rev
>> Log:
>> * subversion/libsvn_wc/wc_db_pdh.c
>>  (pdh_parse_local_abspath): Followup to r1076093 by further allocating bits of
>>    the PDH in the result pool, rather than the db->state_pool.
>>
>> Modified:
>>    subversion/trunk/subversion/libsvn_wc/wc_db_pdh.c
>>
>> Modified: subversion/trunk/subversion/libsvn_wc/wc_db_pdh.c
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db_pdh.c?rev=1076098&r1=1076097&r2=1076098&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/libsvn_wc/wc_db_pdh.c (original)
>> +++ subversion/trunk/subversion/libsvn_wc/wc_db_pdh.c Wed Mar  2 03:07:04 2011
>> @@ -350,7 +350,7 @@ pdh_parse_local_abspath(db_pdh_t **pdh,
>>   if (wcroot != NULL)
>>     {
>>       *pdh = apr_pcalloc(result_pool, sizeof(**pdh));
>> -      (*pdh)->local_abspath = apr_pstrdup(db->state_pool, local_abspath);
>> +      (*pdh)->local_abspath = apr_pstrdup(result_pool, local_abspath);
>>       (*pdh)->wcroot = wcroot;
>>     }
>>   else
>> @@ -397,7 +397,7 @@ pdh_parse_local_abspath(db_pdh_t **pdh,
>>       if (wcroot != NULL)
>>         {
>>           *pdh = apr_pcalloc(result_pool, sizeof(**pdh));
>> -          (*pdh)->local_abspath = apr_pstrdup(db->state_pool, local_abspath);
>> +          (*pdh)->local_abspath = apr_pstrdup(result_pool, local_abspath);
>>           (*pdh)->wcroot = wcroot;
>>         }
>>
>> @@ -437,7 +437,7 @@ pdh_parse_local_abspath(db_pdh_t **pdh,
>>   if (*pdh == NULL)
>>     {
>>       *pdh = apr_pcalloc(result_pool, sizeof(**pdh));
>> -      (*pdh)->local_abspath = apr_pstrdup(db->state_pool, local_abspath);
>> +      (*pdh)->local_abspath = apr_pstrdup(result_pool, local_abspath);
>>     }
>>   else
>>     {
>>
>>
>>
>
Received on 2011-03-02 11:05:27 CET

This is an archived mail posted to the Subversion Dev mailing list.