[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] New XFail test for issue 3826

From: Noorul Islam K M <noorul_at_collab.net>
Date: Wed, 02 Mar 2011 09:54:49 +0530

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:

> r1076100. Review below.
>
> Noorul Islam K M wrote on Wed, Mar 02, 2011 at 09:33:54 +0530:
>> Index: subversion/tests/cmdline/diff_tests.py
>> ===================================================================
>> --- subversion/tests/cmdline/diff_tests.py (revision 1074971)
>> +++ subversion/tests/cmdline/diff_tests.py (working copy)
>> @@ -3760,6 +3760,22 @@
>> svntest.actions.run_and_verify_svn(None, expected_output, [], 'diff',
>> '-c2', '--git')
>> os.chdir(was_cwd)
>> +
>> +@XFail()
>> +@Issue(3826)
>> +def diff_abs_localpath_from_wc_folder(sbox):
>> + "diff absolute localpath from wc folder"
>> + sbox.build(read_only = True)
>> + wc_dir = sbox.wc_dir
>> +
>
> Nice find (that two wc's aren't needed for the issue).
>
>> + a_path = os.path.join(wc_dir, 'A')
>> + b_path = os.path.join(wc_dir, 'A', 'B')
>
> A_path = ...
> B_path = ...
>
>> + was_cwd = os.getcwd()
>> + os.chdir(os.path.abspath(a_path))
>> + svntest.actions.run_and_verify_svn(None, None, [], 'diff',
>> + os.path.abspath(b_path))
>> + os.chdir(was_cwd)
>
> The last chdir() won't get executed if the test fails, so I've removed
> it. (Your caller does a try/finally block that restores the cwd for
> the next test.)

Thank you for tweaking it.

Thanks and Regards
Noorul
Received on 2011-03-02 05:25:36 CET

This is an archived mail posted to the Subversion Dev mailing list.