On Tue, Mar 1, 2011 at 23:30, Julian Foad <julian.foad_at_wandisco.com> wrote:
> On Tue, 2011-03-01 at 21:00 +0100, Stefan Sperling wrote:
>> On Tue, Mar 01, 2011 at 10:07:58PM +0300, Ivan Zhakov wrote:
>> > On Tue, Mar 1, 2011 at 20:47, <julianfoad_at_apache.org> wrote:
>> > > Author: julianfoad
>> > > Date: Tue Mar 1 17:47:04 2011
>> > > New Revision: 1075942
>> > >
>> > > URL: http://svn.apache.org/viewvc?rev=1075942&view=rev
>> > > Log:
>> > > Make the pristine text store guarantee that a pristine text stream being
>> > > read will remain readable even if the text is deleted from the store. To
>> > > ensure that a recently deleted pristine file can be reinstated, on Windows
>> > > we rename it to a new unique name before deleting it. This is probably not
>> > > the most efficient way to work on Windows.
>> > >
>> > [...]
>>
>> > > +#if 1 /*def WIN32*/
>> > I think it should be "#ifdef WIN32". Isn't it?
>>
>> Looks very much like that to me, too.
>> I've made this change in r1076006 because Julian doesn't seem to
>> be around at the moment.
>
> Thanks Ivan and Stefan. Yes, that's what it was meant to be.
>
> It's nice to have had it tested on Linux as well though!
>
> BTW, should it also check for OS/2?
I don't have experience with OS/2, may be someone else know OS/2 behavior.
--
Ivan Zhakov
Received on 2011-03-01 21:40:10 CET