[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Compiling subversion trunk with httpd trunk code fails

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Tue, 1 Mar 2011 23:08:22 +0530

>No! If you are going to use separate functions then write:

>static void log_access_verdict(...)
>{

It still needs a signature change to log_access_verdict.

>#if AP_MODULE_MAGIC_AT_LEAST(...)
> log_access_verdict_httpd_v23(...)
>#else
> log_access_verdict_httpd_v22(...)
>#endif
>}

>so that the callers don't have to change.

>On the whole I preferred the macro solution.

Me to prefer the orignal macro based solution.

With regards
Kamesh Jayachandran
Received on 2011-03-01 18:40:24 CET

This is an archived mail posted to the Subversion Dev mailing list.