[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] HTTPv2 allow client to control transaction name in protocol

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 01 Mar 2011 11:15:28 -0500

On 03/01/2011 10:09 AM, Philip Martin wrote:
> Index: subversion/mod_dav_svn/dav_svn.h
> ===================================================================
> --- subversion/mod_dav_svn/dav_svn.h (revision 1075718)
> +++ subversion/mod_dav_svn/dav_svn.h (working copy)
> @@ -52,6 +52,9 @@
> /* a pool-key for the shared dav_svn_root used by autoversioning */
> #define DAV_SVN__AUTOVERSIONING_ACTIVITY "svn-autoversioning-activity"
>
> +/* used to distinguish client supplied TXN-NAME from FS supplied, this
> + is a string that is NEVER the start of an FS transaction name */
> +#define DAV_SVN__VISIBLE_TXN_PREFIX "$"

Whoops! Technically, mod_dav_svn hasn't access to the knowledge required to
make this assertion. Who says a transaction's name can't start with a
dollar sign?

I'm still at odds with myself about this patch in general. HTTPv2 offers us
a chance to clean up and simplify our protocol, and before it even sees its
first release you want to add a bit of obfuscation and indirection required
solely by one commercial product? Come on. (If you know me at all, you
realize my antagonism is aimed not at said product, but at the proposed
protocol hack.) So I'm trying to convince myself that there's some general
utility to this change -- that somewhere, sometime, somebody else will thank
us for adding it.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2011-03-01 17:16:09 CET

This is an archived mail posted to the Subversion Dev mailing list.