Re: [PATCH] issue #3719 fix slow large checkouts on Windows

On Tue, Mar 01, 2011 at 02:01:34PM +0000, Neil Bird wrote:
> Around about 08/02/11 10:01, Neil Bird typed ...
> Just to re-iterate, what I've done is change
> svn_io_open_unique_file3() so that instead of just calling
> svn_io_open_uniquely_named() it is in fact a verbatim copy of
> svn_io_open_uniquely_named(), except that it uses rand() (after a
> fashion) to generate iterative temporary file names instead of
> counting from 1.

The problem with this approach is that is also changes the numbers
for temporary files used to store log messages. These temporary
files are part of the user interface, in a way.
I think that using random numbers in those files names might confuse people.
And we're generally trying to avoid making such changes in a patch release.

When there are several svn-commit.tmp files, I find it quite convenient
to be able to tell from the filename which file is the latest.

> I'll include the latest patch here, and put it on the bug entry
> for posterity as well.
>
> If you're happy with it, great, if not, well, so be it.

Thanks for trying!

I will try backporting the trunk code to 1.6.x myself.
If that gets anywhere then we can use it.

Else, we could use a slightly modified version of your patch
that keeps the existing behaviour for log message temp files.
Received on 2011-03-01 16:43:13 CET