[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Last batch of performance improvements for 1.7

From: Arnout van Meer <rr2do2_at_splashdamage.com>
Date: Mon, 28 Feb 2011 22:36:41 +0000

On 23 February 2011 08:43, Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de> wrote:
>
> Hi all,
>
> You may have noticed that I prepared yet another bunch
> of changes for integration into /trunk (details below).
> All other remaining changes on the performance branch
> are 1.8 material.
>
> You know the drill: The integration branches can be merged
> independent of each other and a branch will be merged to
> /trunk on the 4th or 5th if
>
> * there was no feedback to it at all (= silent acceptance), or
> * it received positive feedback (= +1 on merge), or
> * issues found have been resolved
>
> So, an easy way to prevent a particular branch from being
> merged is a simple "needs more discussion / review" post.
>
> -- Stefan^2.
>
>
> List of integration branches:
> -----------------------------
>
> integrate-is-cachable
> - replace the fixed 1MB limit to the cachable full-text
>  size in FSFS with a cache-specific implementation
>
> integrate-partial-getter
> - allows access to sub-structures of cached items
> - fixes the O(N^2) performance issue with reports on
>  large directories
>
> integrate-readline-speedup
> - very local change
> - significant speedup in parsing any FSFS structure
>  (e.g. directories) other than full-texts and deltas
>
> integrate-txdelta-caching
> - implements caching to the txdelta hunks
> - enabled for svnadmin only (speedup of dump / verify)
>
>
> Postponed to 1.8:
> -----------------
>
> integrate-string-improvement
> - relatively simple change that mainly speeds up ra_svn clients
>
>

I'm currently integrating these locally to do some performance related
tests, noticed the following few issues (note that I merged the
partial-getter branch before the is-cachable branch, that way code
ends up meeting the performance branch order):

integrate-partial-getter, in cache-memcache.c, in memcache_get_partial:

        mc_key = build_key(cache, key, subpool);

should read:

        SVN_ERR(build_key(&mc_key, cache, key, subpool));

integrate-txdelta-caching causes a test failure:

        START: authz_tests.py
        CMD: svnadmin create svn-test-work/local_tmp/repos --bdb-txn-nosync
        CMD: /home/avmeer/dev/subversion/performance-test/subversion/svnadmin/svnadmin
create svn-test-work/local_tmp/repos --bdb-txn-nosync exited with 127
        <TIME = 0.115648>
        /home/avmeer/dev/subversion/performance-test/subversion/svnadmin/.libs/lt-svnadmin:
error while loading shared libraries: libsvn_fs_util-1.so.0: cannot
open shared object file: No such file or directory
        Traceback (most recent call last):
          File "./build/run_tests.py", line 585, in <module>
            main()
          File "./build/run_tests.py", line 578, in main
            failed = th.run(args[2:])
          File "./build/run_tests.py", line 135, in run
            failed = self._run_test(prog, cnt, len(list)) or failed
          File "./build/run_tests.py", line 467, in _run_test
            (LINE_LENGTH - len(test_info)))
          File "./build/run_tests.py", line 413, in _run_py_test
            test_selection=test_selection)
          File "/home/avmeer/dev/subversion/performance-test/subversion/tests/cmdline/svntest/main.py",
line 1713, in execute_tests
            svntest.actions.setup_pristine_greek_repository()
          File "/home/avmeer/dev/subversion/performance-test/subversion/tests/cmdline/svntest/actions.py",
line 59, in setup_pristine_greek_repository
            main.create_repos(main.pristine_greek_repos_dir)
          File "/home/avmeer/dev/subversion/performance-test/subversion/tests/cmdline/svntest/main.py",
line 734, in create_repos
            raise SVNRepositoryCreateFailure("".join(stderr).rstrip())
        svntest.main.SVNRepositoryCreateFailure:
/home/avmeer/dev/subversion/performance-test/subversion/svnadmin/.libs/lt-svnadmin:
error while loading shared libraries: libsvn_fs_util-1.so.0: cannot
open shared object file: No such file or directory
Received on 2011-02-28 23:37:13 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.