Ping. This updated svn log message has received no comments.
On 18/02/2011, at 3:49 AM, Noorul Islam K M wrote:
> Julian Foad <julian.foad_at_wandisco.com> writes:
>
>> Noorul Islam K M wrote:
>>
>>> Julian Foad <julian.foad_at_wandisco.com> writes:
>>>
>>>> On Thu, 2011-02-17, Noorul Islam K M wrote:
>>>>
>>>>> Noorul Islam K M <noorul_at_collab.net> writes:
>>>>> Log
>>>>> [[[
>>>>>
>>>>> Fix failing expected error regex. Also capture ra_neon error.
>>>>
>>>> Hi Noorul. Writing a good log message is quite a difficult skill to
>>>> learn, so please don't be dismayed at my comment here.
>>>>
>>>
>>> Not at all. I am here to learn.
>>>
>>>> You need to describe the change at a high level. In the context of the
>>>> whole project, what is changing, and why? The line above just suggests
>>>> that this fixes something to do with errors, but doesn't give me a clue
>>>> whether it was a bug in Subversion or a bug in the tests, or what part
>>>> of Subversion's behaviour is affected. Imagine that I am (or Kamesh or
>>>> Stefan or Hyrum is) reading through the output of "svn log" to find
>>>> commits related to bugs in merging, for example: the message should give
>>>> me a clue about whether this change is likely to be relevant.
>>>>
>>>>> * subversion/svn/blame-cmd.c
>>>>> (svn_cl__blame): Catch SVN_ERR_FS_NOT_FOUND and display warning.
>>>>
>>>> As a consequence of not being able to read what is the purpose of this
>>>> patch, I have no idea why you are including this change.
>>>>
>>>
>>> Thank you very much. I will keep these points in mind and with help from
>>> all you I will improve.
>>
>> Please could you try to write a high-level description of this change
>> now. I see stsp has committed it in r1071632 but we can still edit it
>> (a log message is a rev prop and all rev props are editable).
>>
>
> I am giving it another shot.
>
> Log
> [[[
>
> Follow-up to r1071602. In case of ra_neon for non-existing target the
> API returns SVN_ERR_FS_NOT_FOUND. Capture it and print warning and
> make 'blame' continue with next target. Also tweak expected error regex
> to include multiple error codes from different ra_layers.
>
> * subversion/svn/blame-cmd.c
> (svn_cl__blame): Catch SVN_ERR_FS_NOT_FOUND and display warning.
>
> * subversion/tests/cmdline/blame_tests.py
> (blame_non_existent_url_target): Fix expected error regex.
>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
>
> Thanks and Regards
> Noorul
Received on 2011-02-27 12:53:26 CET