Bert Huijben wrote on Fri, Feb 25, 2011 at 15:58:32 +0100:
>
>
> > -----Original Message-----
> > From: Noorul Islam K M [mailto:noorul_at_collab.net]
> > Sent: vrijdag 25 februari 2011 7:40
> > To: Subversion
> > Subject: [PATCH] New XFail test : 'svn up' fails if external propset is
> not
> > committed.
> >
> > Log
> > [[[
> >
> > 'svn up' fails if external propset is not committed.
>
> I'm not sure if we should call this an error/bug.
>
> I think externals were designed to operate only on committed nodes.
>
> This has the nice side effect that when you remove the externals definition
> it gets removed later on.
>
> Once we start parsing externals from property definitions that are only
> edited locally we break this nice feature of automatically removing the
> externals.
>
Fair point. I don't feel strongly on how things should work here, but
I believe the test has a valid point --- viz., it triggers a bogus warning:
[[[
CMD: /home/daniel/src/svn/t1/subversion/svn/svn update svn-test-work/working_copies/externals_tests-29 --config-dir /home/daniel/src/svn/t1/subversion/tests/cmdline/svn-test-work/local_tmp/config --password rayjandom --no-auth-cache --username jrandom exited with 1
<TIME = 0.236354>
Updating 'svn-test-work/working_copies/externals_tests-29' ...
Fetching external item into 'svn-test-work/working_copies/externals_tests-29/A2/iota'
At revision 1.
svn: warning: W155010: The node '/home/daniel/src/svn/t1/subversion/tests/cmdline/svn-test-work/working_copies/externals_tests-29/A2' was not found.
subversion/svn/update-cmd.c:183: (apr_err=205011)
svn: E205011: Failure occurred processing one or more externals definitions
]]]
>
> Note that we already started breaking this feature a bit before this patch,
> because we now check externals definitions on added nodes.
> (Which now has issues of its own; see issue #3819)
>
> Bert
>
Received on 2011-02-26 23:03:30 CET