[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 21 Feb 2011 11:21:10 +0000

Stefan Sperling <stsp_at_elego.de> writes:

> But I think there is value in seeing the error message in the test code.
> It makes it much easier for those reading the test code to follow
> what kind of error the test is expecting. If all people can go by
> is the error code, then they'll have to keep looking up error codes
> to understand what the test is trying to do.
> I think that's worse than adjusting tests when the message changes
> every once in a while.

For those reading the test code a comment could be used, although I
admit that a comment is less reliable. On the other hand, if we just
check error numbers that might make it possible to run the regression
tests in some locale other than C, and some language other than English.

-- 
Philip
Received on 2011-02-21 12:22:01 CET

This is an archived mail posted to the Subversion Dev mailing list.