[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix a bug introduced in r1071025.

From: Noorul Islam K M <noorul_at_collab.net>
Date: Sat, 19 Feb 2011 08:58:55 +0530

Without the patch I get Segmentation fault when I pass unknown command
to svnadmin command.

Log

[[[
Fix a bug introduced in r1071025.

* subversion/svnadmin/main.c
  (parse_args): Handle NULL argument.

Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
]]]

Index: subversion/svnadmin/main.c
===================================================================
--- subversion/svnadmin/main.c (revision 1072234)
+++ subversion/svnadmin/main.c (working copy)
@@ -549,7 +549,7 @@
            int max_expected,
            apr_pool_t *pool)
 {
- int num_args = os->argc - os->ind;
+ int num_args = os ? (os->argc - os->ind) : 0;
 
   if (min_expected || max_expected)
     SVN_ERR_ASSERT(args);
Received on 2011-02-19 04:29:55 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.