I have checked this in at notes/wc-ng/pristine-store and updated it
according to Greg's and your comments so far.
On Wed, 2011-02-16, Julian Foad wrote:
> On Wed, 2011-02-16, Daniel Shahaf wrote:
> > Julian Foad wrote on Tue, Feb 15, 2011 at 15:06:43 +0000:
> > > Would anyone be able to review this spec please? I'm trying to get
> > > straight what locking / access control rules need to be.
> >
> > Sure, review below. Having finished the review, though, I wonder if
> > I amn't missing some details of the big picture while studying all the
> > low-level details. (If I did, please point them out.)
> >
> > > /*
> > > * THE PRISTINE STORE
> > > * ==================
> > > *
> > > * === Introduction ===
[...]
> > > * * Ensure the pristine text remains in the store continuously from
> > > * opening it for the duration of the read. (Perhaps by ensuring
> > > * refcount remains >= 1 and/or by cooperating with the clean-up
> > > * code.)
> >
> > I find this vague: how does one perform the "ensure" steps?
>
> Well, I'm not quite sure yet. TODO.
That's now addressed. (In this case, hold a WC lock or rely on the OS
to preserve the file as long as a file handle is open.)
[...]
> Thanks for all this. I'll do an update (and check it in like Hyrum
> said).
I've updated the doc with most of my response, and left "###" markers in
unresolved places. (r1071795.)
- Julian
Received on 2011-02-17 22:21:29 CET