[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 5.1)

From: Danny Trebbien <dtrebbien_at_gmail.com>
Date: Sun, 13 Feb 2011 20:20:45 -0800

>> +def identity_copy(sbox):
>> +  "copy UTF-8 svn:* props identically"
>> +  orig_lc_all = locale.setlocale(locale.LC_ALL)
>> +  other_locales = [ "English.1252", "German.1252", "French.1252", "en_US.ISO-8859-1", "en_GB.ISO-8859-1", "de_DE.ISO-8859-1" ]
>> +  for other_locale in other_locales:
>> +    try:
>> +      locale.setlocale(locale.LC_ALL, other_locale)
>> +      break
>> +    except:
>> +      pass
>
> Don't you need to check that at least one of the six locales was
> set successfully?

My bad. Yes I should.

Attached are the corrected patch and log message. The new patch
incorporates this fix:
https://github.com/dtrebbien/subversion/commit/190f876b52626be6b30fe4e5a311c113fd87e589

Received on 2011-02-14 05:21:22 CET

This is an archived mail posted to the Subversion Dev mailing list.