[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add a test of svn_subst_translate_string2() to the subst_translate-test test suite

From: Branko Čibej <brane_at_e-reka.si>
Date: Sun, 13 Feb 2011 16:10:03 +0100

On 13.02.2011 09:33, Daniel Shahaf wrote:
>> + strncpy(orig_lc_all, setlocale(LC_ALL, NULL), sizeof orig_lc_all);
> sizeof() with parens please.

Why? They're not necessary unless the sizeof operator (not function!) is
applied to a type name. There's no ambiguity here at all.

-- Brane
Received on 2011-02-13 16:10:49 CET

This message: [ Message body ]
Next message: Daniel Shahaf: "Re: [PATCH] add a test of svn_subst_translate_string2() to the subst_translate-test test suite"
Previous message: Stefan Sperling: "Re: Best way to issue a warning in a C test"
In reply to: Daniel Shahaf: "Re: [PATCH] add a test of svn_subst_translate_string2() to the subst_translate-test test suite"
Next in thread: Daniel Shahaf: "Re: [PATCH] add a test of svn_subst_translate_string2() to the subst_translate-test test suite"
Reply: Daniel Shahaf: "Re: [PATCH] add a test of svn_subst_translate_string2() to the subst_translate-test test suite"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.