On Sat, Feb 12, 2011 at 07:22:09PM +0200, Daniel Shahaf wrote:
> stsp_at_apache.org wrote on Sat, Feb 12, 2011 at 17:09:14 -0000:
> > +++ subversion/trunk/subversion/libsvn_repos/repos.c Sat Feb 12 17:09:14 2011
> > @@ -1369,6 +1369,7 @@ svn_repos_create(svn_repos_t **repos_p,
>
> +1
>
> > Modified: subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py
> > URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py?rev=1070113&r1=1070112&r2=1070113&view=diff
> > ==============================================================================
> > --- subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py (original)
> > +++ subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py Sat Feb 12 17:09:14 2011
> > @@ -919,6 +919,17 @@ def create_in_repo_subdir(sbox):
> > subdir = os.path.join(repo_dir, 'Z')
> > svntest.main.create_repos(subdir)
> > except svntest.main.SVNRepositoryCreateFailure:
> > + pass
>
> The test used to fail if this except() block didn't run. Could you
> restore that behaviour?
See r1070117.
> > +
> > + cwd = os.getcwd()
> > + try:
> > + # This should fail, too
> > + subdir = os.path.join(repo_dir, 'db', 'revs')
> > + os.chdir(subdir)
> > + svntest.main.create_repos('Z')
> > + os.chdir(cwd)
> > + except svntest.main.SVNRepositoryCreateFailure:
> > + os.chdir(cwd)
> > return
> >
>
> +1, except that db/revs doesn't exist in BDB repositories.
Oops! See r1070116.
Thanks!
Received on 2011-02-12 18:38:06 CET