[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1068029 - /subversion/trunk/subversion/libsvn_subr/io.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 10 Feb 2011 10:47:23 +0100

> -----Original Message-----
> From: steveking_at_apache.org [mailto:steveking_at_apache.org]
> Sent: maandag 7 februari 2011 18:43
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1068029 -
> /subversion/trunk/subversion/libsvn_subr/io.c

<snip>

> svn_error_t *
> svn_io_set_file_read_write_carefully(const char *path,
> @@ -3197,10 +3326,24 @@ dir_make(const char *path, apr_fileperms
> #ifdef APR_FILE_ATTR_HIDDEN
> if (hidden)
> {
> +#ifndef WIN32
> status = apr_file_attrs_set(path_apr,
> APR_FILE_ATTR_HIDDEN,
> APR_FILE_ATTR_HIDDEN,
> pool);
> +#else
> + /* on Windows, use our wrapper so we can also set the
> + FILE_ATTRIBUTE_NOT_CONTENT_INDEXED attribute */
> + status = apr_win_file_attrs_set(path_apr,
> + FILE_ATTRIBUTE_HIDDEN |
> + FILE_ATTRIBUTE_NOT_CONTENT_INDEXED
> |
> + FILE_ATTRIBUTE_DIRECTORY,
> + FILE_ATTRIBUTE_HIDDEN |
> + FILE_ATTRIBUTE_NOT_CONTENT_INDEXED
> |
> + FILE_ATTRIBUTE_DIRECTORY,
> + pool);

Why do you try to set the directory attribute here?
(You can't turn a file into a directory :))

But maybe a more interesting question: Maybe we should also set the system attribute to make the directory a bit more hidden?

        Bert
Received on 2011-02-10 10:48:04 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.