On 07.02.2011 19:23, C. Michael Pilato wrote:
> On 02/07/2011 12:31 PM, Stefan Küng wrote:
>> On 07.02.2011 16:28, C. Michael Pilato wrote:
>>> Is there at least some attribution that needs to happen if we add it to our
>>> codebase?
>>
>> Actually, it's a copy of the function utf8_to_unicode_path() that's part of
>> apr, but apr doesn't export that function :(
>> That's why we need a copy of it.
>>
>> But the comment above the function should already tell you that?
>
> Doh! I managed to completely overlook that comment. Sorry, Stefan. :-(
>
> Is the function suitable for export from APR? I mean, it's is
> public-API-worthy like that? Maybe we should point to its general utility
> and get the APR folks to make that happen.
It's a Windows-only function. Not sure what the policy is here, maybe
apr doesn't allow exporting OS specific functions.
But other than that, it's perfectly fine to export it. And since that
function seems to be copied elsewhere too as you've noticed, it may be
worth exporting it to avoid even more copies of it.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Received on 2011-02-07 19:34:04 CET