Hyrum K Wright wrote:
> > - SVN_ERR(svn_checksum_mismatch_err(svn_dirent_local_style(fb->path, pool),
> > - text_checksum, actual_checksum, pool));
> > + SVN_ERR(svn_checksum_mismatch_err(text_checksum, actual_checksum, pool,
> > + _("Checksum mismatch for '%s'"),
> > + svn_dirent_local_style(fb->path, pool)));
>
> Although the use of svn_checksum_mismatch_err() simplifies the code
> and consolidates various messages for translation, it does have one
> drawback: the call to svn_dirent_local_style() is now unconditional,
> rather than only being invoked in the (unlikely) event of a checksum
> mismatch. Is this enough of a drawback that I should revert the past
> couple of commits in this area?
Maybe this indicates that the new public API should be one that simply
generates a checksum-mismatch error message (but doesn't do the
comparison), and a private/local wrapper should be used when it is
desired to combine the comparison and the error message creation into a
single call.
- Julian
Received on 2011-02-04 22:23:21 CET