Johan Corveleyn wrote on Thu, Feb 03, 2011 at 22:47:23 +0100:
> On Wed, Feb 2, 2011 at 5:53 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > Johan Corveleyn wrote on Tue, Feb 01, 2011 at 13:28:24 +0100:
> >> So: I've tried removing SVN_USE_WIN32_CRASHHANDLER from gen_win.py
> >> (put it in comment, ran "nmake config" and rebuilt everything), then
> >> ran update_tests.py again: same result. It still crashes, and shows
> >> the ugly blocking popup.
> >>
> >
> > I don't use Windows as my day-to-day OS any more, but I suppose it'll be
> > a good idea to adhere to my old promise to commit that Makefile once it
> > has seen some testing :-). Johan, could you do that? Or send it to me
> > and I'll do it.
>
> Hi Daniel,
>
> Yes, great idea. This could definitely help get other people working
> on Windows interested in svn development (it helped me getting
> started). Here is the Makefile I'm currently using, but I don't think
> it's ready to be committed right away, with my local paths in it and
> all, and lots of custom tweaks to make it work for my needs.
>
r1067056, and I added some TODO's in README. We can handle them on an
as-needed basis.
I added some tweaks --- to avoid requiring a 'test.exe' binary, etc ---
I guess you'll see them when you diff the files. (I also diffed your
Makefile against the one I'd mailed the list a while ago.)
I also reverted some of your 'don't require version number for
dependencies' changes... but thinking again I think that might not have
a good move. So feel free to add them back!
> If I have some time, I'll try to clean it up a little. But right now,
> attaching it to this mail is all I can do :-).
>
> Some changes I made to the original you sent me (from memory):
> - Fiddled around with the dependencies, until they worked for me.
> - Added Programs\diff, Programs\diff3 and Programs\diff4 to the "all1"
> and "all2" targets, because I needed them (for the diff-opitimizations
> testing). Added corresponding copy statement in the package target.
>
On Unix, 'make' now implies 'make tools' (as of a couple of months ago).
We should do the same on Windows.
> Maybe other things, but I don't remember (right now, I'm just copying
> this Makefile around if I need to build a new branch that I checked
> out (only need to change the paths in the beginning of the file)).
>
> Cheers,
> Johan
>
Thanks!
Daniel
> > Belatedly,
> >
> > Daniel
> > (as sibling to stsp's tools/dev/unix-build/ I suggest)
> >
> >> Anyone else who recently built trunk on Windows seeing this, when
> >> running update_tests.py?
> >>
> >> --
> >> Johan
> >
Received on 2011-02-04 02:20:13 CET