On Wed, Feb 02, 2011 at 10:15:36PM +0100, Bert Huijben wrote:
>
>
> > -----Original Message-----
> > From: stsp_at_apache.org [mailto:stsp_at_apache.org]
> > Sent: woensdag 2 februari 2011 21:08
> > To: commits_at_subversion.apache.org
> > Subject: svn commit: r1066604 - /subversion/trunk/subversion/svn/main.c
> >
> > Author: stsp
> > Date: Wed Feb 2 20:07:43 2011
> > New Revision: 1066604
> >
> > URL: http://svn.apache.org/viewvc?rev=1066604&view=rev
> > Log:
> > * subversion/svn/main.c
> > (svn_cl__cmd_table): On Windows, escape the caret in merge help text
> > examples
> > using the ^/ URL shortcut notation. This is required by cmd.exe.
> > E.g. 'svn merge ^/trunk' becomes 'svn merge ^^/trunk'
> > The same could be done for one example in 'svn help switch', but that
> > would make getopt_test 7 fail and I have no way to run tests on Windows.
>
> This patch most likely breaks localization of this text and I'm not sure if we should really change the examples to show the quoting. If this is a cmd.exe requirement I don't think we should perform the escaping as there are more ways to run svn than just from cmd.
>
I was thinking of people who copy-paste the examples onto the command
line. I suppose people who aren't using cmd.exe are more likely to know
what they need to type than others.
Well, I had to revert it anyway because it broke the Windows build.
Sorry about the noise.
> Adding some note suggesting the quoting after the main help text might be more appropriate and this would be easier to localize.
Agreed.
Stefan
Received on 2011-02-02 22:45:10 CET