"Bert Huijben" <bert_at_qqmail.nl> writes:
>> -----Original Message-----
>> From: Noorul Islam K M [mailto:noorul_at_collab.net]
>> Sent: dinsdag 1 februari 2011 5:58
>> To: dev_at_subversion.apache.org
>> Subject: Re: [PATCH] New XFail tests for issue 3609
>>
>> Noorul Islam K M <noorul_at_collab.net> writes:
>>
>> > Log
>> >
>> > [[[
>> >
>> > New XFail tests for issue 3609.
>> >
>> > * subversion/tests/cmdline/mergeinfo_tests.py
>> > (mergeinfo_url_special_characters, test_list),
>> > subversion/tests/cmdline/prop_tests.py
>> > (props_url_special_characters, test_list),
>> > subversion/tests/cmdline/merge_tests.py
>> > (merge_url_special_characters, test_list),
>> > subversion/tests/cmdline/log_tests.py
>> > (log_url_special_characters, test_list),
>> > subversion/tests/cmdline/copy_tests.py
>> > (copy_url_special_characters, test_list),
>> > subversion/tests/cmdline/blame_tests.py
>> > (blame_url_special_characters, test_list):
>> > New XFail tests.
>> >
>> > Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
>> > ]]]
>> >
>> > Index: subversion/tests/cmdline/mergeinfo_tests.py
>> > ===================================================================
>> > --- subversion/tests/cmdline/mergeinfo_tests.py (revision 1062140)
>> > +++ subversion/tests/cmdline/mergeinfo_tests.py (working copy)
>> > @@ -479,6 +479,18 @@
>> > adjust_error_for_server_version(''),
>> > ['4', '5'], A_path, A_COPY_path + '@PREV', '--show-revs',
>> 'eligible')
>> >
>> > +def mergeinfo_url_special_characters(sbox):
>> > + """special characters in svn mergeinfo URL"""
>> > +
>> > + sbox.build()
>> > + wc_dir = sbox.wc_dir
>> > + special_url = sbox.repo_url + '/%2E'
>
> With an url like http://server/svn/repos
> and %2E = '.'
>
> This would create an url as 'http://server/svn/repos/%2E'
>
> Following our canonicalization rules this would be a non-canonical
> equivalent to http://server/svn/repos (via http://server/svn/repos/.)
>
> I just added a few tests for this specific scenarios in
> subversion/tests/libsvn_subr/dirent_uri_tests.c, which showed that
> svn_uri_canonicalize() doesn't handle this case correctly.
> (svn_uri_canonicalize() returned "http://server/svn/repos/.", which is not
> canonical by itself)
>
> I committed a fix in r 1066006, so you might need a different special
> character to trigger your issue. (Or maybe this just fixed the issue?)
Do you mean this test cases will pass with you fix? If so, is it not
okay to add these test cases? May be not as XFail?
Thanks and Regards
Noorul
Received on 2011-02-01 12:43:53 CET