[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1065170 - in /subversion/branches/diff-optimizations-bytes/subversion/libsvn_diff : diff_file.c lcs.c

From: Daniel Shahaf <danielsh_at_apache.org>
Date: Sun, 30 Jan 2011 17:17:51 +0200

Johan Corveleyn wrote on Sun, Jan 30, 2011 at 15:32:00 +0100:
> On Sun, Jan 30, 2011 at 4:17 AM, <danielsh_at_apache.org> wrote:
> > @@ -377,7 +381,6 @@ find_identical_prefix(svn_boolean_t *rea
> > -  apr_ssize_t max_delta, delta;
...
> > @@ -503,7 +506,7 @@ find_identical_suffix(struct file_info f
> > -  svn_boolean_t is_match, can_read, can_read_word, reached_prefix;
> > +  svn_boolean_t is_match, can_read, reached_prefix;
>
> Same here. The variable 'can_read_word' is used inside the
> SVN_UNALIGNED_ACCESS_IS_OK block, at line 573 and following.
>
> So, how should these be handled? Can we only declare those two
> variables if SVN_UNALIGNED_ACCESS_IS_OK?

+1, sorry for the bug. (Usually I grep for a variable name when I get
an "unused" error, I can't explain why I missed it this time.)

Fixed in r1065305.

> Or maybe we can rearrange the code a little bit to make it more clear
> at the same time ...

Yes; see the log message.
Received on 2011-01-30 16:22:27 CET

This is an archived mail posted to the Subversion Dev mailing list.