[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1064093 - /subversion/trunk/subversion/libsvn_repos/authz.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 27 Jan 2011 19:48:13 +0200

C. Michael Pilato wrote on Thu, Jan 27, 2011 at 10:23:02 -0500:
> We should probably release-note this change.

+1

> It might be a rare situation,
> but *if* folks have come to depend on the case-sensitivity of these checks,
> they need to prepare for the fallout of this loosening of the policy.
>

Sorry for not thinking about this earlier, but:
Why was the fix to make all checks case-INsensitive, as opposed to
making all checks case-sensitive?

(If this was discussed before, I'd appreciate a pointer to the
discussion.)

>
> On 01/27/2011 06:41 AM, kameshj_at_apache.org wrote:
> > Author: kameshj
> > Date: Thu Jan 27 11:41:43 2011
> > New Revision: 1064093
> >
> > URL: http://svn.apache.org/viewvc?rev=1064093&view=rev
> > Log:
> > Fix for Issue #3781 repo prefix rules in authz section is checked case
> > sensitively for write operations
> >
> > * subversion/libsvn_repos/authz.c
> > (authz_get_any_access_parser_cb): Use strncasecmp() instead of strncmp()
> >
> > Patch by: me
> > Arwin Arni <arwin{_AT_}collab.net>
> >
> > Modified:
> > subversion/trunk/subversion/libsvn_repos/authz.c
> >
> > Modified: subversion/trunk/subversion/libsvn_repos/authz.c
> > URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/authz.c?rev=1064093&r1=1064092&r2=1064093&view=diff
> > ==============================================================================
> > --- subversion/trunk/subversion/libsvn_repos/authz.c (original)
> > +++ subversion/trunk/subversion/libsvn_repos/authz.c Thu Jan 27 11:41:43 2011
> > @@ -398,8 +398,8 @@ authz_get_any_access_parser_cb(const cha
> >
> > /* Does the section apply to the query? */
> > if (section_name[0] == '/'
> > - || strncmp(section_name, b->repos_path,
> > - strlen(b->repos_path)) == 0)
> > + || strncasecmp(section_name, b->repos_path,
> > + strlen(b->repos_path)) == 0)
> > {
> > b->allow = b->deny = svn_authz_none;
> >
> >
> >
>
>
> --
> C. Michael Pilato <cmpilato_at_collab.net>
> CollabNet <> www.collab.net <> Distributed Development On Demand
Received on 2011-01-27 18:52:50 CET

This is an archived mail posted to the Subversion Dev mailing list.