[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for Issue #3781 repo prefix rules in authz section is checked case sensitively for commit

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Thu, 27 Jan 2011 17:14:47 +0530

On 01/20/2011 11:38 AM, Arwin Arni wrote:
> On Wednesday 19 January 2011 09:46 PM, C. Michael Pilato wrote:
>> On 01/19/2011 10:52 AM, Arwin Arni wrote:
>>> Hi All,
>>>
>>> Authz section names(and paths too) are parsed/loaded in a case
>>> insensitive way.
>>>
>>> So they need to be compared in a case-insensitive way.
>>>
>>> Following functions do authz,
>>>
>>> 1. libsvn_repos/authz.c:authz_get_path_access()
>>> 2. libsvn_repos/authz.c:authz_get_any_access() is called when the
>>> "path" is
>>> NULL (for MKACTIVITY, DELETE).
>>>
>>> '1' is leaving it to svn_config_enumerate2() to handle case
>>> (in)sensitiveness.
>>> '2' is explicitly comparing each config item in a case sensitive way.
>>>
>>> My patch is just fixing the '2' to check it in a case insensitive way.
>>
>> So, just to be clear, now read and write access checks will both
>> compare the
>> repository name in a case-insensitive way?
>>
> That's Correct.
>>> Index: subversion/libsvn_repos/authz.c
>>> ===================================================================
>>> --- subversion/libsvn_repos/authz.c (revision 1060836)
>>> +++ subversion/libsvn_repos/authz.c (working copy)
>>> @@ -398,7 +398,7 @@
>>>
>>> /* Does the section apply to the query? */
>>> if (section_name[0] == '/'
>>> - || strncmp(section_name, b->repos_path,
>>> + || strncasecmp(section_name, b->repos_path,
>>> strlen(b->repos_path)) == 0)
>>
>> You've goofed up the indentation here.
>>
> Again.. extremely sorry.. I guess I'm still not completely accustomed
> to the indentation conventions.. Here's a patch with the indentation
> fixed..
>

Thanks Arwin. Committed the patch in r1064093.

With regards
Kamesh Jayachandran
> Regards,
> Arwin Arni
Received on 2011-01-27 12:44:38 CET

This is an archived mail posted to the Subversion Dev mailing list.