[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Status of the branch diff-optimizations-bytes branch

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Thu, 27 Jan 2011 02:10:03 +0100

On Wed, Jan 26, 2011 at 7:18 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Johan Corveleyn wrote on Wed, Jan 26, 2011 at 15:18:24 +0100:
>> - The only internal caller of the "old" function 'datasource_open'
>> (for a single datasource) doesn't call it anymore
>> (token.c#svn_diff__get_tokens) (there is no need anymore, since the
>> callers in diff.c, diff3.c and diff4.c already open the datasources
>> with 'datasources_open' before calling svn_diff__get_tokens).
>
> Does datasource_open() need to stay in the revved struct?

I don't think so. There are no callers left in svn's own code, so I
guess it can be deprecated.

Cheers,

-- 
Johan
Received on 2011-01-27 02:11:03 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.