[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add include of "svn_dirent_uri.h" to mod_authz_svn.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 12 Jan 2011 20:55:51 +0100

On Wed, Jan 12, 2011 at 07:50:11PM +0000, Piper, Nick wrote:
> This is a follow up to a previously submitted patch which was applied, see http://mail-archives.apache.org/mod_mbox/subversion-dev/201011.mbox/%3C87fwvigwgr.fsf@stat.home.lan%3E and r1030536 r1030540.
>
> It seems that patch was missing:
>
> #include "svn_dirent_uri.h"
>
> Without this, we get a warning:
>
> subversion/mod_authz_svn/mod_authz_svn.c:161: warning: assignment makes pointer from integer without a cast
>
> and subsequent breakage on 64-bit platforms where the return pointer is truncated.
>
> I'm sorry for this oversight in the original patch.
>
> Patch against trunk:
>
> Index: subversion/mod_authz_svn/mod_authz_svn.c
> ===================================================================
> --- subversion/mod_authz_svn/mod_authz_svn.c (revision 1058279)
> +++ subversion/mod_authz_svn/mod_authz_svn.c (working copy)
> @@ -42,6 +42,7 @@
> #include "svn_config.h"
> #include "svn_string.h"
> #include "svn_repos.h"
> +#include "svn_dirent_uri.h"
>
>
> extern module AP_MODULE_DECLARE_DATA authz_svn_module;

Applied, thanks!

Stefan
Received on 2011-01-12 20:56:34 CET

This is an archived mail posted to the Subversion Dev mailing list.