[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH in progress] Ref-counting for pristine texts

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Tue, 11 Jan 2011 13:20:16 +0000

On Tue, 2011-01-11, Julian Foad wrote:
> The complete patch (with log message) is attached. Any review would be
> appreciated.

To be more specific:

I'm happy with the way this patch uses triggers to inc and dec the ref
counts. Review of impl details here would be appreciated.

I'm not 100% sure whether close_wcroot() is the best place to delete
unreferenced pristines. Review of the concept would be useful here, in
comparison with other options such as deleting after flushing the work
queue or at some other place.

In any case, I think this is good enough (modulo the debugging code as
identified by ### in the log message) to commit tomorrow and improve
afterwards.

- Julian
Received on 2011-01-11 14:21:02 CET

This is an archived mail posted to the Subversion Dev mailing list.