[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] pass NULL instead of an unused parameter

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Tue, 11 Jan 2011 17:23:56 +0530

On 01/11/2011 05:05 PM, Prabhu Gnana Sundar wrote:
> Hi all,
>
> Currently, when creating a repo, svnadmin accepts the --config-dir
> option. But clearly, the code does not use the 'config' option being
> passed. Hence I am passing NULL value instead of sending the 'config'
> value.
>
> This change has passed all the tests and is working fine.
> I have attached the patch and the log message with this mail. Please
> review...
>
>
>
> Thanks and regards
> Prabhu

Hi Prabhu,

> SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool));
> SVN_ERR(svn_repos_create(&repos, opt_state->repository_path,
> NULL, NULL,
>- config, fs_config, pool));
>+ NULL, fs_config, pool));

If you do not need 'config' as well you need *not* populate it.

With regards
Kamesh Jayachandran
Received on 2011-01-11 12:54:14 CET

This is an archived mail posted to the Subversion Dev mailing list.