[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

From: Danny Trebbien <dtrebbien_at_gmail.com>
Date: Mon, 10 Jan 2011 08:55:35 -0800

>> Perhaps, though, I should use svn_subst_translate_string2() with the
>> encoding set to "UTF-8". It would greatly simplify normalize_string(),
>
> +1.  Just call it with encoding=NULL; using the same API in both
> branches makes life easier for the next person to revv that API.

One thing that worries me about using NULL for ENCODING is that
svn_subst_translate_string2() calls svn_utf_cstring_to_utf8() on the
string in that case, implying some sort of re-encoding from the native
narrow string encoding to UTF-8. Couldn't this be problematic?
Received on 2011-01-10 17:56:13 CET

This is an archived mail posted to the Subversion Dev mailing list.