[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1056468 - in /subversion/trunk: contrib/hook-scripts/remove-zombie-locks.py subversion/include/svn_fs.h subversion/libsvn_fs_base/lock.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 07 Jan 2011 15:02:15 -0500

On 01/07/2011 02:55 PM, Blair Zajac wrote:
> On 01/07/2011 11:33 AM, cmpilato_at_apache.org wrote:
>> Author: cmpilato
>> Date: Fri Jan 7 19:33:28 2011
>> New Revision: 1056468

[...]

>> + svn_io_file_seek(args.spool_file, APR_SET,&offset, pool);
>
> Need to handle the error here?

[...]

>> + get_locks_func(get_locks_baton, lock, iterpool);
>
> And here too, since svn_fs_get_locks_callback_t has an svn_error_t * return
> type.

Thanks, Blair. Committed those fixes in r1056480.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2011-01-07 21:02:55 CET

This is an archived mail posted to the Subversion Dev mailing list.