[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] make diff against copy-source by default

From: Prabhu Gnana Sundar <prabhugs_at_collab.net>
Date: Fri, 07 Jan 2011 21:29:20 +0530

Hi Julian,

On Fri, 2011-01-07 at 12:17 +0000, Julian Foad wrote:
> I can't look into this in detail, but I have two thoughts:
>
> 1. Ideally, I would expect the structure of the diff code to be
> something like:
>
> libsvn_client:
> call libsvn_wc to get the WC file;
> call libsvn_ra to get the repos file;
> call libsvn_diff to compare the two files;
> report the results.
>
> So libsvn_wc would not need to read files from the repository.
>
> 2. If for some reason the code is structured such that libsvn_wc does
> need to fetch a repository file, it should do so via a callback function
> provided by libsvn_client, not by calling libsvn_client or libsvn_ra
> functions directly. There is already some code somewhere in libsvn_wc
> that uses a callback into libsvn_client to fetch a file's text from the
> repository. I can't remember where.

That's really cool...
You are absolutely right in your points. The first suggestion does not
hold in certain cases where the 'source file' would not be available in
the text-base.

I will look closely into your second suggestion :)

Thanks and regards
Prabhu
Received on 2011-01-07 17:09:02 CET

This is an archived mail posted to the Subversion Dev mailing list.