svn_client_update4 depth: exclude and externals

Hello.

Currently svn 1.7-trunk doesn't support excluding externals from wc,
altough it used to.(Sometime between multi-db and single-db it stopped working)

It seems that in (libsvn_wc/crop.c) in function svn_wc_exclude at
line:220 checks
only if it is root (contains admin area) and errors out if so and it doesn't
see/check bigger picture (prop external).

Further there is deeper in exclude proccess (libsvn_wc/adm_ops.c)
in svn_wc__internal_remove_from_revision_control at line 1928
call to svn_wc__adm_destroy even though there is no admin directory
since single-db.

Either one could fix exclude of externals (ommiting while checkout/"update to"
lasts until next update,then externals are added again) or remove
call to svn_wc__adm_destroy.(if excluding externals was/is unwanted)

As for fixing, one would have to inform in some way svn_wc_exclude
about case (external/wc root).

Last thing:current 1.7-trunk also leaves behind directories containing externals
after exclude.

Thanks.

Daniel Klima

P.S.:I tried to fit manualy in 72-chars width while using gmail,so I might
have misscounted or misscorrect.
(at least I never saw option for char/column width in gmail)
Received on 2011-01-06 13:35:07 CET