[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] '--version --quiet' should display only the version info in svnadmin, svnlook, svnsync, svndumpfilter, svnversion, svnserve

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 05 Jan 2011 10:04:54 -0500

On 01/05/2011 09:37 AM, C. Michael Pilato wrote:
> On 01/05/2011 06:42 AM, Prabhu Gnana Sundar wrote:
>> Hi all,
>>
>> Currently svnadmin, svnlook, svnsync, svndumpfilter, svnversion,
>> svnserve show the entire version information even if '--version --quiet'
>> is given as command.
>>
>> The '--quiet' option has *not* been handled so far.
>>
>> This patch would make svnadmin, svnlook, svnsync, svndumpfilter,
>> svnversion, svnserve '--version --quiet' to display *only* the version
>> number(info) just like 'svn --version --quiet' does.
>
> Mmm... consistency. Consistency makes me smile.
>
>> I have attached the patch and the log message with this mail. Please
>> give your views on this.
>
> I have reviewed this patch and will commit it shortly (after some testing).

Committed in r1055478. Thanks!

>> Index: subversion/svnlook/main.c
>> ===================================================================
>> --- subversion/svnlook/main.c (revision 1055432)
>> +++ subversion/svnlook/main.c (working copy)
>> @@ -176,6 +176,9 @@
>> " "
>> " Ignore changes in EOL style")},
>>
>> + {"quiet", 'q', 0,
>> + N_("no progress (only errors) to stderr")},
>> +
>
> There are some code formatting/indentation inconsistencies here which didn't
> originate with your change, but which your change extends.

And fixed these other indentation issues in r1055481.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2011-01-05 16:05:35 CET

This is an archived mail posted to the Subversion Dev mailing list.