Noorul Islam K M <noorul_at_collab.net> writes:
> Noorul Islam K M <noorul_at_collab.net> writes:
>
>> "Hyrum K. Wright" <hyrum_wright_at_mail.utexas.edu> writes:
>>
>>> On Wed, Dec 22, 2010 at 12:27 AM, Noorul Islam K M <noorul_at_collab.net> wrote:
>>>
>>>>
>>>> Find attached minor patch which makes 'if' syntax consistent and also
>>>> some comment improvements.
>>>>
>>>> Log
>>>>
>>>> [[[
>>>>
>>>> Fix syntax inconsistency and update comments.
>>>>
>>>> * libsvn_client/locking_commands.c
>>>> (organize_lock_targets): Fix syntax inconsistency. Update comments.
>>>
>>> *What* about the syntax inconsistency are you fixing? White space?
>>> Function names? Use of braces? (I can tell by looking at the patch,
>>> but a more informative log message would be nice.)
>>>
>>> Same with "update comments". Update them in what way?
>>>
>>
>> Please find updated log message.
>>
>> [[[
>>
>> Fix syntax inconsistency and update comments.
>>
>> * libsvn_client/locking_commands.c
>> (organize_lock_targets): Fix syntax inconsistency by removing
>> unnecessary braces from 'if' block. Update comments to reflect new
>> function names used.
>>
>> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
>> ]]]
>>
>
> I was thinking that this one is a trivial fix.
>
Just reminding so that someone take a look at this patch. I know this is
not so important but still wonder why such a trivial patch takes time to
get reviewed and committed.
Thanks and Regards
Noorul
Received on 2011-01-04 09:56:11 CET