[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

From: Branko ─îibej <brane_at_xbc.nu>
Date: Wed, 29 Dec 2010 21:12:42 +0100

On 29.12.2010 20:10, Kamesh Jayachandran wrote:
>
> >> Now I'm really mystified. When I added those location-tracing functions
> >> and macros, they were only ever enabled with SVN_DEBUG turned on (i.e.,
> >> in maintainer-mode). Now I see that those #ifdef wrappers are gone, and
> >> can't recall an explanation as to why that's a good thing.
> >>
> >> Can anyone remember what that change was good for?
>
> >Found it, r843793 and I agree with the change. So, effectively,
> >svn_error__locate has been public since then, and r1053469 should be
> >reverted anyway because it breaks the ABI.
>
> Not sure why r1053469 need to be reverted. IIUC it still keeps the
> svn_error__locate by changing it to NOOP. Which I think is enough to
> keep ABI.
>

Read the log of r843793 to see why -- the idea is not to make it a
no-op, but to keep the location info there for debuggers.

Granted, that could be done in a better way, however, the macros need to
stay outside of SVN_DEBUG until someone implements that better way.

-- Brane
Received on 2010-12-29 21:13:25 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.