Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c
Ping, this doesn't seem to have been fixed yet?
Bert Huijben wrote on Mon, Oct 11, 2010 at 10:58:38 +0200:
> > -----Original Message-----
> > From: artagnon_at_apache.org [mailto:artagnon_at_apache.org]
> > Sent: maandag 4 oktober 2010 17:27
> > To: commits_at_subversion.apache.org
> > Subject: svn commit: r1004286 - in /subversion/trunk: ./
> > subversion/libsvn_subr/io.c
> > Author: artagnon
> > Date: Mon Oct 4 15:26:44 2010
> > New Revision: 1004286
> > URL: http://svn.apache.org/viewvc?rev=1004286&view=rev
> > Log:
> > Merge r985477 from subversion/branches/performance
> > * subversion/libsvn_subr/io.c
> > (get_default_file_perms): Store the permissions of the created
> > temporary file in a static variable and re-use it in subsequent
> > calls instead of checking persmissions everytime. This has
> > performance benefits.
> > Review by: artagnon
> > Approved by: julianfoad
> Delayed review:
> Shouldn't this function use some 'atomic initialization' handling?
> Currently it uses a static apr_fileperms_t (integer?) which can be manipulated by multiple threads at the same time.
> This part of subversion is a library and inside tools like Subclipse, TortoiseSVN, AnkhSVN and others it is used multithreaded.
Received on 2010-12-27 16:41:02 CET
This is an archived mail posted to the Subversion Dev