[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix syntax inconsistency and update comments.

From: Noorul Islam K M <noorul_at_collab.net>
Date: Sat, 25 Dec 2010 09:13:20 +0530

Noorul Islam K M <noorul_at_collab.net> writes:

> "Hyrum K. Wright" <hyrum_wright_at_mail.utexas.edu> writes:
>
>> On Wed, Dec 22, 2010 at 12:27 AM, Noorul Islam K M <noorul_at_collab.net> wrote:
>>
>>>
>>> Find attached minor patch which makes 'if' syntax consistent and also
>>> some comment improvements.
>>>
>>> Log
>>>
>>> [[[
>>>
>>> Fix syntax inconsistency and update comments.
>>>
>>> * libsvn_client/locking_commands.c
>>>  (organize_lock_targets): Fix syntax inconsistency. Update comments.
>>
>> *What* about the syntax inconsistency are you fixing? White space?
>> Function names? Use of braces? (I can tell by looking at the patch,
>> but a more informative log message would be nice.)
>>
>> Same with "update comments". Update them in what way?
>>
>
> Please find updated log message.
>
> [[[
>
> Fix syntax inconsistency and update comments.
>
> * libsvn_client/locking_commands.c
> (organize_lock_targets): Fix syntax inconsistency by removing
> unnecessary braces from 'if' block. Update comments to reflect new
> function names used.
>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
>

I was thinking that this one is a trivial fix.

Thanks and Regards
Noorul
Received on 2010-12-25 04:51:03 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.