[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1051763 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_repos/commit.c mod_dav_svn/version.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 23 Dec 2010 13:18:30 +0200

Julian Foad wrote on Wed, Dec 22, 2010 at 16:43:16 +0000:
> On Wed, 2010-12-22, Blair Zajac wrote:
> > On 12/22/10 4:36 AM, Julian Foad wrote:
> > > subversion/libsvn_repos/commit.c:648: no previous prototype for
> > > 'svn_repos__post_commit_error_str'
> >
> > Thanks, fixed in r1051968.
> >
> > Which compiler are you using that gives this warning?
>
> GCC.
>
> >From the output of "make":
>
> [...]/libtool --tag=CC --silent --mode=link gcc -Wno-system-headers
> -Wold-style-definition -Wdeclaration-after-statement -Wpointer-arith
> -Wwrite-strings -Wshadow -ansi -Wall -Wformat=2 -Wunused
> -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes
> -Wmissing-declarations -Wno-multichar -Wredundant-decls -Wnested-externs
> -Wunreachable-code -Winline -Wno-long-long -g -DAPR_POOL_DEBUG -Wundef
> -Wendif-labels -Wcast-qual -Wno-deprecated-declarations
> -Wno-unreachable-code -Wno-format-nonliteral -pthread
> -D_LARGEFILE64_SOURCE -DNE_LFS -Werror=implicit-function-declaration
> -DSVN_DEBUG -DAP_DEBUG [...]
>
> (The first group of options are inserted by Subversion's configury, and
> my config/build/test script sets CFLAGS to "-g -O -DAPR_POOL_DEBUG
> -Wundef -Wendif-labels

> -Wcast-qual

This one generates a couple dozen warnings for me....

> -Wno-deprecated-declarations -Wno-unreachable-code -Wno-format-nonliteral".)

With these three, I now have a warning-free build --- thanks!

(after r1052225, and modulo the svn-populate-node-origin issue from
yesterday)

>
> - Julian
>
>

Daniel
(using gcc 4.3.2 on Debian)
Received on 2010-12-23 12:21:27 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.