[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 5.2)

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Tue, 21 Dec 2010 00:11:01 +0000

On Mon, 2010-12-20, Danny Trebbien wrote:
> [[[
> Add a public API function, svn_subst_translate_string2(), an extension of
> svn_subst_translate_string(), that has two additional output parameters for
> determining whether re-encoding and/or line ending translation were performed.

Thanks, Danny.

Committed revision 1051322.

The main patch looks great. In the test file, I made the minimum
changes necessary to comply with the C'89 language (no // comments, no
declarations after code), and committed it. However I suggest many
further changes to the test code, mainly making it data-driven (use a
table of inputs and expected outputs) and use helpers such as
SVN_TEST_STRING_ASSERT() to maximize readability. To this end, I
suggest the version attached here. Do you want to check this for me, to
see if it still does what you wanted it to, and let me know if I should
commit it.

Thanks again.
- Julian

Received on 2010-12-21 01:11:45 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.