[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_fs_commit_txn and svn_repos_fs_commit_txn inconsistency

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 20 Dec 2010 14:32:31 -0500

On 12/20/2010 02:14 PM, Blair Zajac wrote:
> Shouldn't svn_repos_fs_commit_txn() always run the post-commit hook if
> new_rev is a valid rev?

That does seem reasonable, yes.

> BTW, we should have the docs for svn_fs_commit_txn mention that *new_rev is
> always modified, so the caller doesn't have to set *new_rev to

We normally don't make that sort of doc statement. But, in a case such as
this -- where success/fail is determined by something other than an error
value -- I agree that it makes sense.

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-12-20 20:33:14 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.