[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Testing help/advice needed.

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 14 Dec 2010 12:14:00 -0500

I've got a patch readied for issue #3755 ("svnadmin and svnrdump should
error on non-UTF8 log messages, authors, etc."), but it currently fails
three tests:

FAIL: svnlook_tests.py 4: svnlook info must allow inconsistent newlines
FAIL: svnrdump_tests.py 32: dump: inconsistent line endings in svn:props
FAIL: svnsync_tests.py 26: copy with inconsistent lineendings in svn:props

All three fail for the same reason. Can you guess it? It's because the
tests are depending on the ability of 'svnadmin load' to introduce bogus
properties into a Subversion repository so that *other* validation code can
be tested.

What to do about this?

Is there a case to be made for allowing 'svnadmin load' to, upon specific
request by the user (via a new --disable-prop-validation flag or something),
*not* error out on invalid properties? If so, then I can create and make
use of such a facility in these test scenarios. But if not, what then? Do
I remove the tests? Do I mark them as FSFS-only and try to hack around in
the FSFS data format from the test suit? Do I write a quicky little C
program that bypasses the libsvn_repos propchange validation logic, for use
with these Python tests?

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-12-14 18:14:43 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.