[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: transform_libtool_scripts.py

From: Martin Furter <mf_at_rola.ch>
Date: Tue, 14 Dec 2010 12:28:03 +0100 (CET)

On Tue, 14 Dec 2010, Stefan Sperling wrote:

> On Tue, Dec 14, 2010 at 11:09:34AM +0100, Martin Furter wrote:
>> Replace a disgusting shell script by nice python code.
>> transform_libtool_scripts.py is more portable and also reads build.conf.
>
> While python is required to create buidscripts for a subversion distribution
> tarball, we do not require python for compiling the tarball.
> Because transform_libtool_scripts is run during 'make' your patch isn't
> going to work.
>
> Can you try to fix the .sh script instead?

Trying to read and parse build.conf from a shell script doesn't sound sane
to me and it would make transform_libtool_scripts.sh even less
maintainable.

What about generating transform_libtool_scripts.sh from gen_make.py ?
Received on 2010-12-14 12:28:40 CET

This is an archived mail posted to the Subversion Dev mailing list.