[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] support printing changed properties in svnlook

From: Erik Johansson <erik_at_ejohansson.se>
Date: Mon, 13 Dec 2010 22:27:04 +0100

On Fri, Dec 10, 2010 at 14:29, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Could you untangle this mess around driving the editor?  (I might be
> able to look into this later, but not right now)

See attempt in other thread.

[snip a discussion I'll have to get back to later]

>> >> +} svn_repos_node_prop_t;
>> >
>> > I'm afraid you can't extend this struct due to binary compatibility
>> > considerations (an application built against 1.6 but running against 1.7
>> > will create too short a struct).
>> This was actually one of my concerns as well. I will try to come up
>> with another way of doing it.

I've been thinking some more about this:
- svn_repos_node_t is never used as an in parameter, so there
shouldn't be any need for applications to create one.
- If an application creates a svn_repos_node_t, the only use for it
would be internal to the application in which case it will use its
version of the struct even if we change it.
- If we add the new field to the end of the struct there should be no
problems for applications built with an old version of the struct;
they will simply not be able to access the new field.

What do you think?

// Erik

Erik Johansson
Home Page: http://ejohansson.se/
PGP Key: http://ejohansson.se/erik.asc
Received on 2010-12-13 22:27:44 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.