[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Missing SVN_ERR() wraps

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 13 Dec 2010 18:21:59 +0200

danielsh_at_apache.org wrote on Fri, Dec 10, 2010 at 18:18:43 -0000:
> Author: danielsh
> Date: Fri Dec 10 18:18:42 2010
> New Revision: 1044467
> URL: http://svn.apache.org/viewvc?rev=1044467&view=rev
> Log:
> Fix error leaks.
> * everywhere:
> Add missing SVN_ERR() calls.

Johan, there are a few missing SVN_ERR() on the -bytes branch too ---
e.g., none(!) of the calls to increment_pointers() check the return
value. Please fix :)

@all, let me repeat that I would be happy if we had a way to have
a tool warn us of these omissions. Right now, my only idea is to add
a warn_unused_result decoration on every single function declaration
in our code. And while we could do that, I hoped there would be an
easier way.

Received on 2010-12-13 17:24:37 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.