Re: Input validation observations

Noorul Islam K M wrote:
> Attached is the patch for svn/diff-cmd.c. All tests pass.

Hi Noorul. Thanks for mentioning that all tests pass - that's good to
know.

> + svn_cl__assert_homogeneous_target_type(targets);
> +
> /* Check to see if at least one of our paths is a working copy
> path. */
> for (i = 0; i < targets->nelts; ++i)

After you have asserted that all the targets are of the same type, there
is no need for a loop that checks all of them in turn, just to find out
whether they are paths or URLs, is there?

- Julian

> {
> const char *path = APR_ARRAY_IDX(targets, i, const char *);
> if (! svn_path_is_url(path))
> - working_copy_present = TRUE;
> - else
> - url_present = TRUE;
> + {
> + working_copy_present = TRUE;
> + break;
> + }
> }
[...]
Received on 2010-12-10 13:01:17 CET